-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create new ttr for tiertemplate updates #1130
feat: create new ttr for tiertemplate updates #1130
Conversation
/retest updated e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have 2 slight readability improvement suggestions, otherwise looks great!
Co-authored-by: Lukas Krejci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Co-authored-by: Matous Jobanek <[email protected]>
Co-authored-by: Matous Jobanek <[email protected]>
/retest updated e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Feny Mehta <[email protected]>
|
/retest flaky proxy test, looking into it ... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 79.52% 79.46% -0.06%
==========================================
Files 80 81 +1
Lines 8087 8128 +41
==========================================
+ Hits 6431 6459 +28
- Misses 1471 1481 +10
- Partials 185 188 +3
|
This PR triggers a TTR creation when the tiertemlpate content changes or there is a change in the NSTemplateTier parameters field.
follow up from #1103
Paired with: codeready-toolchain/toolchain-e2e#1102
Jira: https://issues.redhat.com/browse/KUBESAW-257