Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create new ttr for tiertemplate updates #1130

Merged
merged 39 commits into from
Feb 10, 2025

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented Jan 24, 2025

This PR triggers a TTR creation when the tiertemlpate content changes or there is a change in the NSTemplateTier parameters field.

follow up from #1103

Paired with: codeready-toolchain/toolchain-e2e#1102

Jira: https://issues.redhat.com/browse/KUBESAW-257

mfrancisc and others added 27 commits December 7, 2023 12:21
@mfrancisc
Copy link
Contributor Author

/retest

updated e2e

Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have 2 slight readability improvement suggestions, otherwise looks great!

@mfrancisc mfrancisc requested a review from metlos January 30, 2025 15:40
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

controllers/nstemplatetier/mapper.go Outdated Show resolved Hide resolved
controllers/nstemplatetier/mapper_test.go Show resolved Hide resolved
@mfrancisc
Copy link
Contributor Author

/retest

updated e2e

Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

controllers/nstemplatetier/mapper.go Outdated Show resolved Hide resolved
Copy link

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,fbm3307,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarqubecloud bot commented Feb 7, 2025

@mfrancisc
Copy link
Contributor Author

/retest

flaky proxy test, looking into it ...

@mfrancisc mfrancisc merged commit 3a68afe into codeready-toolchain:master Feb 10, 2025
11 of 13 checks passed
@mfrancisc mfrancisc deleted the difftiertemplate branch February 10, 2025 12:50
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 70.68966% with 17 lines in your changes missing coverage. Please review.

Project coverage is 79.46%. Comparing base (f255b6c) to head (18fcac6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ollers/nstemplatetier/nstemplatetier_controller.go 64.00% 7 Missing and 2 partials ⚠️
controllers/nstemplatetier/mapper.go 72.41% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1130      +/-   ##
==========================================
- Coverage   79.52%   79.46%   -0.06%     
==========================================
  Files          80       81       +1     
  Lines        8087     8128      +41     
==========================================
+ Hits         6431     6459      +28     
- Misses       1471     1481      +10     
- Partials      185      188       +3     
Files with missing lines Coverage Δ
test/nstemplatetier/assertion.go 100.00% <100.00%> (ø)
controllers/nstemplatetier/mapper.go 72.41% <72.41%> (ø)
...ollers/nstemplatetier/nstemplatetier_controller.go 81.16% <64.00%> (-2.28%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants